Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Infra] Add check for unexpected test failures in build.sh #14144

Merged
merged 6 commits into from
Nov 20, 2024
Merged

[Infra] Add check for unexpected test failures in build.sh #14144

merged 6 commits into from
Nov 20, 2024

Conversation

andrewheard
Copy link
Contributor

@andrewheard andrewheard commented Nov 18, 2024 •
edited
Loading

When xcodebuild test fails due to a crash (example), instead of a typical test failure, the exit code is 0 (success). These show up as passing in our CI jobs. Added a regex check to detect this scenario.

#no-changelog

@andrewheard andrewheard marked this pull request as ready for review November 20, 2024 18:12
@andrewheard andrewheard requested a review from paulb777 November 20, 2024 18:12
@andrewheard andrewheard merged commit db77a77 into main Nov 20, 2024
66 checks passed
@andrewheard andrewheard deleted the ah/build-check-crashes branch November 20, 2024 18:15
@firebase firebase locked and limited conversation to collaborators Dec 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ncooke3 ncooke3 ncooke3 approved these changes

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andrewheard @paulb777 @ncooke3 @google-oss-bot